[alsa-devel] [PATCH 2/4] ASoC: sgtl5000: defer the probe if clock is not found
Russell King - ARM Linux
linux at arm.linux.org.uk
Mon Jul 1 13:33:10 CEST 2013
On Mon, Jul 01, 2013 at 10:45:25AM +0100, Mark Brown wrote:
> On Mon, Jul 01, 2013 at 04:16:09PM +0800, Shawn Guo wrote:
> > It's not always the case that clock is already available when sgtl5000
> > get probed at the first time, e.g. the clock is provided by CPU DAI
> > which may be probed after sgtl5000. So let's defer the probe when
> > devm_clk_get() call fails and give it chance to try later.
> Why not fix this in the clock API - the same logic is going to apply to
> a great proportion of clocks?
It's not ever clear whether a missing clock is because it's just not
provided or whether it's because it hasn't been registered yet. The
decision to defer on missing resources is something which a _driver_
using the resource should make, not the subsystem providing the
resource - because the driver should know better whether that resource
is optional, whether it can continue to initialise without it and maybe
try again later, or whether it does need to defer.
Take for instance a video driver. :) It may be that it can't do all
resolutions, but it can do some without an external clock, so it may
decide that it can initialise without the external clock and allow one
of the possible modes to be set - and when the external clock does
appear, it can then allow the other modes.
That kind of information is unknown at the subsystem level, and so the
subsystem level should only ever return "I don't know about this" not
More information about the Alsa-devel