[alsa-devel] [PATCH 1/4] ASoC: sgtl5000: give it a ramping time before writting
broonie at kernel.org
Mon Jul 1 12:07:10 CEST 2013
On Mon, Jul 01, 2013 at 04:16:08PM +0800, Shawn Guo wrote:
> + /*
> + * It seems that sgtl5000 takes a longer time to get the registers
> + * ready for write than bread. Let's give it a ramping time before
> + * the first write goes.
> + */
> + msleep(50);
> /* Ensure sgtl5000 will start with sane register values */
> ret = sgtl5000_fill_defaults(sgtl5000);
> if (ret)
This seems like a really odd place to add the sleep - I'd have expected
this to be a part of or just after the reset operation. It's a *really*
long sleep too, though if that's what you need that's what you need.
Also "bread" :)
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel