[alsa-devel] [PATCH] ALSA: core: don't return uninitialized snd_compr_tstamp

Vinod Koul vinod.koul at intel.com
Thu Jan 31 03:53:54 CET 2013

On Thu, Jan 31, 2013 at 10:37:12AM +0800, Mark Brown wrote:
> From: Richard Fitzgerald <rf at opensource.wolfsonmicro.com>
> The snd_compr_update_tstamp() can only fill in the snd_compr_tstamp
> if the codec implements the pointer() function. If that happened
> the code was previously returning uninitialized garbage in the
> tstamp because it wasn't initialized anywhere.
> This change zero-fills the tstamp in the two places it is used
> before calling snd_compr_update_tstamp(), and also has
> snd_compr_update_tstamp() return an error indication if it
> can't provide a tstamp. For the case of snd_compr_calc_avail()
> it ignores this error because we still need to return info on
> the available buffer space even if we can't provide tstamp
> info - when the tstamp is not valid all fields are now
> guaranteed to be zero.
> Signed-off-by: Richard Fitzgerald <rf at opensource.wolfsonmicro.com>
> Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
Acked-by: Vinod Koul <vinod.koul at intel.com>


More information about the Alsa-devel mailing list