[alsa-devel] [PATCH V6 04/10] spi: s3c64xx: Modify SPI driver to use generic DMA DT support

[Padma Venkat]

On Tue, Jan 29, 2013 at 10:49 AM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Fri, Jan 18, 2013 at 05:17:03PM +0530, Padmavathi Venna wrote:
>> This patch modifies the SPI driver to use generic dma dt bindings
>> support. This passes all the required arguments to dma dev request
>> functon which in turn calls the dma_request_slave_channel or dma__
>> request_channel based on DT or non-DT respectively.
>
> This loooks OK and I'm actually applying SPI patches so I could apply it
> but I'm not sure I see the relevance of this patch to the rest of the
> series (which is about ASoC).  Is there some reason why it's included in
> this patch series or can it be applied to the SPI tree?  The SMDKs use
> I2C for their CODEC control rather than SPI.
>
> Also is there a binding document update or device tree file update to go
> with this?
>
>> +     if (!sdd->pdev->dev.of_node) {
>> +             res = platform_get_resource(pdev, IORESOURCE_DMA,  0);
>> +             if (!res) {
>> +                     dev_err(&pdev->dev, "Unable to get SPI tx dma "
>> +                                     "resource\n");
>
> I appreciate that this is cut'n'paste from the code you're refactoring
> but please don't split error messages over lines, it makes it hard to
> grep for them in the kernel source.

OK.

Thanks for reviewing.
Padma