[alsa-devel] [PATCH 03/19] ALSA: ymu831: add B-DSP driver
yuasa at linux-mips.org
Thu Jan 17 06:59:12 CET 2013
On Wed, 16 Jan 2013 13:22:45 +0000
Mark Brown <broonie at opensource.wolfsonmicro.com> wrote:
> On Wed, Jan 16, 2013 at 05:28:32PM +0900, Yoichi Yuasa wrote:
> > Signed-off-by: Yoichi Yuasa <yuasa at linux-mips.org>
> > ---
> > sound/soc/codecs/ymu831/Makefile | 1 +
> > sound/soc/codecs/ymu831/mcbdspdrv.c | 1193 +++++++++++++++++++++++++++++++++++
> Why the subdirectory?
ymu831 driver has 27 files.
It is the reason that I made the subdirectory.
Is it better to put them on sound/soc/codes ?
> Also this file is over 1000 lines of code with
> basically no comments or relationship with standard kernel code. This
> is a substandial barrier to review; at the very least it would be
> helpful to split this up into multiple patches, one per algorithm for
OK, I'll split it.
> > +/*
> > + * changelog:
> > + * - change in the Linux coding style
> > + * - remove unnecessary comments
> > + * - remove unused codes
> > + */
> No changelogs in kernel code.
OK, I'll remove them.
Thank you for your comments.
More information about the Alsa-devel