[alsa-devel] [PATCH 06/19] ALSA: ymu831: add device interface driver

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Jan 16 14:36:36 CET 2013

On Wed, Jan 16, 2013 at 05:32:04PM +0900, Yoichi Yuasa wrote:

> +static struct mcdrv_bus_ops *mc_bus_ops;
> +
> +void mc_bus_register(struct mcdrv_bus_ops *ops)
> +{
> +	mc_bus_ops = ops;
> +}
> +

Again this just doesn't look like a serious effort has been made to
integrate whatever thise code does into Linux.  Without some description
of what this is trying to abstract it's hard to comment about what
you're doing here.

The use of a static variable is also a big warning sign here.

More information about the Alsa-devel mailing list