[alsa-devel] [PATCH 03/19] ALSA: ymu831: add B-DSP driver

[Mark Brown]

On Wed, Jan 16, 2013 at 05:28:32PM +0900, Yoichi Yuasa wrote:
> 
> Signed-off-by: Yoichi Yuasa <yuasa at linux-mips.org>
> ---
>  sound/soc/codecs/ymu831/Makefile    |    1 +
>  sound/soc/codecs/ymu831/mcbdspdrv.c | 1193 +++++++++++++++++++++++++++++++++++

Why the subdirectory?  Also this file is over 1000 lines of code with
basically no comments or relationship with standard kernel code.  This
is a substandial barrier to review; at the very least it would be
helpful to split this up into multiple patches, one per algorithm for
example.

> +/*
> + * changelog:
> + * - change in the Linux coding style
> + * - remove unnecessary comments
> + * - remove unused codes
> + */

No changelogs in kernel code.