[alsa-devel] [PATCH 2/5] ASoC: twl6040: Prevent extra power transitions during resume

Peter Ujfalusi peter.ujfalusi at ti.com
Fri Jan 11 14:55:53 CET 2013

On 01/11/2013 02:46 PM, Mark Brown wrote:
> On Fri, Jan 11, 2013 at 02:40:20PM +0100, Peter Ujfalusi wrote:
>> Since the core saves the previous bias_level in before suspend I can just do
>> this here:
>> 	twl6040_set_bias_level(codec, codec->dapm.suspend_bias_level);
>> If we were in _OFF before it is going to do nothing, but if we were in
>> _STANDBY it brings the codec back.
> That'll work, yes (though removing the function when idle_bias_off is
> implemented would obviously be better).

True. Along with the suspend function since I'm not doing anything fancy there
and if idle_bias_off is set the core will not call suspend of the driver if it
is not already in _OFF.
I'll keep this in mind for the future and resend with only with

	twl6040_set_bias_level(codec, SND_SOC_BIAS_STANDBY);

in the resume.
But I wait if you have other comments for the rest for the series.


More information about the Alsa-devel mailing list