[alsa-devel] davici-mcasp: "tx-num-evt" confusion with number of serializers

Daniel Mack zonque at gmail.com
Thu Feb 28 14:19:21 CET 2013

On 28.02.2013 12:02, Michal Bachraty wrote:
> On Thursday, February 28, 2013 10:32:15 Mike Looijmans wrote:
>> That's a big improvement over "rx_num_evt". The first time I saw this
>> struct, I thought I had to set rx_num_evt to the number of receiving AXR
>> pins in use.
>> Maybe call it "rx_min_fifo_depth" because just "depth" might be
>> interpreted as the capaciity or maximum size of the fifo, while in fact
>> the parameter is a minimum amount of data to be put into the FIFO
>> buffer. Of maybe "rx_fifo_thd" to indicate it's a threshhold. And use
>> the same name for the "tx" part as well (tx_fifo_thd or tx_fifo_min_depth).
>  "rx_min_fifo_depth" or  "tx_min_fifo_depth"  seem to be fine.
> If I'll have time, I'll prepare patch. That's cosmetic upgrade, but should 
> help others.

Be careful with such changes. In general, DT bindings are forever in
general, because you can't update all the users out there, and so every
binding that has ever existed has to be supported in the future, for
backwards compatibility.

In this case, we might make an exception, given that for AM33xx, the
necessary DMA bits are still not missing, and Davinci is not yet fully
ported to DT either. So nobody really uses the driver on this platforms.

I copied Mark, Grant and Hebbar to get their opinions.


More information about the Alsa-devel mailing list