[alsa-devel] [PATCH 4/5] ASoC: max98090: Remove unnecessary braces

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Feb 20 17:52:58 CET 2013


On Mon, Feb 18, 2013 at 05:02:13PM +0530, Sachin Kamat wrote:

> -	if (val >= 1) {
> -		if (w->reg == M98090_REG_MIC1_INPUT_LEVEL) {
> +	if (val >= 1){

Your coding style fixes shouldn't introduce new coding style issues
and...

> +		if (w->reg == M98090_REG_MIC1_INPUT_LEVEL)

...in cases where you're nesting with other if statements it's often
clearer to have the braces consistently over all levels of the
conditional.

For the isolated if statements this is fine though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130220/be01d1e4/attachment.sig>


More information about the Alsa-devel mailing list