[alsa-devel] hda_analyzer failed

[Manolo Díaz]

El mié, 6 feb 2013 a las 13:35 horas
Raymond Yau escribió:

>>>
>>>  > File "/dev/shm/hda-analyzer/hda_proc.py", line 143, in wrongfile
>>>  >     raise ValueError, "wrong proc file format (%s)" % msg
>>>  > ValueError: wrong proc file format (integer decode 'State of AFG node
>>> 0x01:' ('Node '))
>>>  >
>>>  > Any ideas?
>>>
>>> This patch add lines which make the parser of hda_proc.py fail
>>>
>>>
>http://git.kernel.org/?p=linux/kernel/git/tiwai/sound.git;a=commitdiff;h=f4f0a8c4783a0258f2d0020a67fd619ce41a02a3;hp=e4cc6153401fc59d6d4ca0317be5774bdbd399ba
>>>
>>
>> Sigh, this is not the first time new stuff in the proc file crashes
>hda_analyzer.
>>
>> Jaroslav, can you please fix hda_analyzer so that it ignores new stuff in
>the proc file instead of crashing, so we don't have this problem over and
>over again?
>>
>
>I don`t understand why the parser have to ignore new stuff
>
>BTW, why hda_proc query the connection list of vendor defined widget ?
>
>http://git.kernel.org/?p=linux/kernel/git/tiwai/hda-emu.git;a=blob;f=codecs/ad1882-sparta;hb=HEAD
>
>Node 0x23 [Vendor Defined Widget] wcaps 0xf00100: Mono
>   Connection: -22

Hi,

I can't see such error message. What steps must I follow to raise it? I
can't see a control node 0x01 either. Is it the control labeled
codec-0?


git branch
* (no branch)
  master
  test/hda-gen-parser
  test/hda-migrate

git show
commit f4f0a8c4783a0258f2d0020a67fd619ce41a02a3
Author: David Henningsson <david.henningsson at canonical.com>
Date:   Tue Jan 8 15:01:18 2013 +0100

    ALSA: hda - print power state for AFG node in proc file
    
    It seems useful, and power states are required for AFG nodes,
    so I see no reason not to print it. As a bonus, also print the
    AFG nid.
    
    Signed-off-by: David Henningsson <david.henningsson at canonical.com>
    Signed-off-by: Takashi Iwai <tiwai at suse.de>

diff --git a/sound/pci/hda/hda_proc.c b/sound/pci/hda/hda_proc.c
index 045e5d3..d6c8416 100644
--- a/sound/pci/hda/hda_proc.c
+++ b/sound/pci/hda/hda_proc.c
@@ -603,6 +603,8 @@ static void print_codec_info(struct snd_info_entry *entry,
        print_amp_caps(buffer, codec, codec->afg, HDA_INPUT);
        snd_iprintf(buffer, "Default Amp-Out caps: ");
        print_amp_caps(buffer, codec, codec->afg, HDA_OUTPUT);
+       snd_iprintf(buffer, "State of AFG node 0x%02x:\n", codec->afg);
+       print_power_state(buffer, codec, codec->afg);
 
        nodes = snd_hda_get_sub_nodes(codec, codec->afg, &nid);
        if (! nid || nodes < 0) {


-- 
Manolo Díaz
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: alsa-info.txt
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130206/076daad6/attachment-0001.txt>