[alsa-devel] [PATCH] ASOC: imx: audmux: add a integrated configuration function

Shawn Guo shawn.guo at linaro.org
Fri Feb 1 14:10:09 CET 2013

On Fri, Feb 01, 2013 at 12:35:19AM +0800, Mark Brown wrote:
> On Thu, Jan 31, 2013 at 10:22:45PM +0800, Shawn Guo wrote:
> > Mark,
> > I just found there are much more code between imx_sgtl5000_probe
> > and imx_wm8962_probe than just above audmux setup.  I'm thinking
> > about consolidate them at a higher level.  But can you give it a
> > go on Gary's patch, and then I can start the consolidation from
> > there?  I promise I will send a follow-up patch to do it.
> I'm not sure what you mean here?  I don't have any intention to work on
> this stuff.

You had a comment on Gary's imx-wm8962 patch, saying that the audmux
setup should become a helper.  And that's why Gary came up this patch.
But the patch does not look good.  While reviewing the patch, I found
there are much more than just audmux setup code could be shared between
imx-sgtl5000 and imx-wm8960 driver.  I'm asking if you can merge Gary's
the patch with leaving audmux setup as it is, and let me consolidate
the common part between imx-sgtl5000 and imx-wm8960 with a follow-up

In any case, I'm not expecting you work on this stuff :)


More information about the Alsa-devel mailing list