[alsa-devel] [PATCH 16/19] ASoC: tegra: Don't set unused struct snd_pcm_hardware fields

Stephen Warren swarren at wwwdotorg.org
Fri Dec 20 18:43:35 CET 2013

On 12/20/2013 06:20 AM, Lars-Peter Clausen wrote:
> The ASoC core assumes that the PCM component of the ASoC card transparently
> moves data around and does not impose any restrictions on the memory layout or
> the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
> the PCM driver that are related to this. Setting these fields in the PCM driver
> might suggest otherwise though, so rather not set them.

I suppose that makes sense; the data format is determined by the FIFO in
the DAI/controller, not the DMA engine that's pushing the data there
(unless DMA can do data conversions, though I think our HW can't?).

Tested-by: Stephen Warren <swarren at nvidia.com>
Acked-by: Stephen Warren <swarren at nvidia.com>

More information about the Alsa-devel mailing list