[alsa-devel] [PATCH] ALSA: hda - Don't be too specific for conflicting boost ctl names
david.henningsson at canonical.com
Fri Dec 20 14:54:05 CET 2013
On 12/20/2013 02:36 PM, Raymond Yau wrote:
> >>> When a boost control influences on multiple input paths, we
> >>> pick up the name string specific to one input but rather choose
> a more
> >>> generic name. A problem seen often is that a single mic boost
> >>> controls both internal and external mics although the driver
> picks up
> >>> the very first name randomly like "Internal Mic Boost". This should
> >>> have been "Mic Boost", instead.
> >>> This patch tries to correct that behavior: when a boost control is
> >>> available, check whether it conflicts with other inputs. If it
> >>> use a common string ("Mic", "Line") as long as possible, or take a
> >>> generic name "Input".
> >> Hrm. I thought today "Mic Boost" is quite common, and meaning the mic
> >> boost of the non-internal mic. So I agree there is a problem -
> and thank
> >> you for trying to fix it - but isn't this just changing one
> problem for
> >> another? Now we don't know if a "Mic Boost" control controls the
> >> internal mic or not.
> > That's true, and the problem isn't new...
> > I'm fine to use a different name as a boost control used for multiple
> > mics, though. Spell your wish.
> If *all* inputs go through the boost, then just preferring "Capture
> Boost" or "Input Boost" over "Mic Boost" would do the trick. I e, just
> skip the logic that checks for all inputs being of the same type.
> not all inputs go through the boost,
> only two mic share boost but line in, CD, aux, stereo mix don't
So what is your suggestion for a better and more consistent name?
David Henningsson, Canonical Ltd.
More information about the Alsa-devel