[alsa-devel] [RFC PATCH 15/15] ACPI/thinkpad: Fix wrong <acpi/acpi.h> inclusion in Thinkpad ACPI users.
tiwai at suse.de
Wed Dec 18 14:06:15 CET 2013
At Wed, 18 Dec 2013 09:41:17 -0200,
Henrique de Moraes Holschuh wrote:
> On Wed, 18 Dec 2013, Lv Zheng wrote:
> > CONFIG_ACPI dependent code should include <linux/acpi.h> instead of
> > directly including <acpi/acpi.h>. This patch cleans up such wrong
> > inclusions for Thinkpad ACPI users.
> > drivers/platform/x86/thinkpad_acpi.c | 1 -
> > include/linux/thinkpad_acpi.h | 2 ++
> > sound/pci/hda/patch_conexant.c | 1 -
> > sound/pci/hda/patch_realtek.c | 1 -
> I'd prefer if you left the include outside of thinkpad_acpi.h, and just fix
> the include in the two ALSA users.
> We might add some extra stuff to thinkpad_acpi.h someday, and not everything
> thinkpad_acpi does that might be useful to export to other areas of the
> kernel would require acpi.h.
> Looking at patch_conexant and patch_realtek, it might be better to actually
> move the "am I running on a thinkpad" stuff they use acpi.h for into
> thinkpad_acpi, and provide a prototype for that in thinkpad_acpi.h.
True, but we don't want to bind with thinkpad_acpi before identified
that it's a thinkpad, so the code needs to be in hd-audio codec
More information about the Alsa-devel