[alsa-devel] [PATCH] ASoC: mmp-pcm: config pcm slave via generic dmaengine

[Lars-Peter Clausen]

On 12/18/2013 12:03 PM, Mark Brown wrote:
> On Wed, Dec 18, 2013 at 10:16:36AM +0100, Lars-Peter Clausen wrote:
> 
>> +#ifdef CONFIG_CPU_MMP2
>> +	/*
>> +	 * Temporary hack until we have a generic gen_pool lookup
>> +	 * infrastructure.
>> +	 */
>> +	if (!pool)
>> +		pool = sram_get_gpool("asram");
>> +#endif
> 
> I worry about what this'd do on a multiplatform kernel - it seems
> unlikely that someone has a pool with the same name but that sounds like
> famous last words.  Nothing in mainline does though so...

The sram_get_gpool() function is mmp2 specific. It basically iterates a list
of available pools. Those pools are registered by mmp2 platform code. So on
a multiplatform kernel not booting mmp2 it will always return NULL since no
pools have been registered.

- Lars