[alsa-devel] [PATCH v2 RESEND 2/2] ASOC: tegra: fix AC97 clock handling

Lucas Stach dev at lynxeye.de
Tue Dec 17 15:49:53 CET 2013

Am Dienstag, den 17.12.2013, 14:00 +0000 schrieb Mark Brown:
> On Tue, Dec 17, 2013 at 11:52:44AM +0100, Lucas Stach wrote:
> > This corrects the Tegra AC97 clock handling to be in line with
> > the devicetree. Audio PLL is controlled by the machine driver, only
> > AC97 host controller clock remains to be independent.
> I don't understand this commit message at all I'm afraid.  What does it
> mean to "be in line with the devicetree" and what is the purpose of this
> change?
Clocks were added to the DT after the Tegra AC97 driver was initially
pushed upstream and the layout changed a bit in the process. Stephen
Warren convinced me that it's the right thing to let the Audio PLL be
controlled by the ASoC machine driver, rather than the AC97 host
controller driver.

So currently the host controller driver asks for clocks that aren't
there in the DT. This change corrects the clock handling so that the
host controller driver only ask for it's own clock, but the Audio PLL
handling is pushed into the machine driver.


> I should also have mentioned on the previous patch: please use subject
> lines matching the subsystem.  You've got "ASOC" not "ASoC".

More information about the Alsa-devel mailing list