[alsa-devel] [PATCH 2/2] ASoC: samsung: Use ASoC dmaengine code where possible
padma.kvr at gmail.com
Fri Dec 6 06:14:19 CET 2013
On Thu, Dec 5, 2013 at 7:55 PM, Mark Brown <broonie at kernel.org> wrote:
> From: Mark Brown <broonie at linaro.org>
> Since all Exynos platforms have been converted to dmaengine and many of
> the older platforms are in the process of conversion they do not need to
> use the legacy s3c-dma APIs for DMA but can instead use the standard ASoC
> dmaengine helpers. This both allows them to benefit from improvements
> implemented in the generic code and supports multiplatform.
> This patch includes some fixes from Padma for Exynos SoCs.
> Signed-off-by: Mark Brown <broonie at linaro.org>
> Tested By: Padmavathi Venna <padma.v at samsung.com>
> I think this should reflect all your testing but a recheck would be good.
I couldn't test this patch set due to some crash in recent kernel in
dmaengine_unmap_put. I think this unmap support is not yet implemented
for pl330 driver. It is mentioned in the commit "dmaengine: prepare
for generic 'unmap' data", [bzolnier: prepare pl330 driver for adding
missing unmap while at it].
> +int samsung_asoc_dma_platform_register(struct device *dev)
> + return snd_dmaengine_pcm_register(dev, &samsung_dmaengine_pcm_config,
> + SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME |
> + SND_DMAENGINE_PCM_NO_RESIDUE |
This flag should be SND_DMAENGINE_PCM_FLAG_NO_RESIDUE.
> + SND_DMAENGINE_PCM_FLAG_COMPAT);
More information about the Alsa-devel