[alsa-devel] [PATCH] ASoC: samsung: Initialize the dma_data for secondary dai
broonie at kernel.org
Thu Dec 5 12:50:15 CET 2013
On Thu, Dec 05, 2013 at 04:33:19PM +0530, Padma Venkat wrote:
> On Thu, Nov 28, 2013 at 5:08 PM, Mark Brown <broonie at kernel.org> wrote:
> > Why don't we need this fix for mainline? The dmaengine change is just
> > moving the initialisation through a layer of indirection but there was
> > initialisation anyway. I'm concerned that there's a bug that ought to
> > be fixed for v3.13 as well here.
> Yes. We need this for mainline. Not dependent on your dmaengine changes.
Ah, just saw this one - I'll cook up a version of it, due to the
refactoring the change doesn't apply directly to v3.13.
> >> return snd_dmaengine_pcm_register(dev, &samsung_dmaengine_pcm_config,
> >> - SND_DMAENGINE_PCM_FLAG_COMPAT);
> >> + SND_DMAENGINE_PCM_FLAG_COMPAT |
> >> + SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME);
> > This is already done.
> Should I send another patch by removing this flag from this patch?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel