[alsa-devel] [PATCH] ASoC: omap-pcm: Lower the dma coherent mask to 32bits
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Dec 5 10:56:19 CET 2013
On Thu, Dec 05, 2013 at 10:06:42AM +0200, Peter Ujfalusi wrote:
> The underlying API dma_coerce_mask_and_coherent() checks the requested bits
> mask against the size of dma_addr_t which is 32bits on OMAP.
> Because of the previously used 64bits mask audio was not probing after
> commit c9bd5e6 (and 4dcfa6007).
> 32bits for the DMA_BIT_MASK looks to be the correct one to use.
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi at ti.com>
> Hi Mark,
> This is the fix for OMAP audio for 3.13-rc2+. The dma coherent changes went in
> between -rc1 and -rc2 which broke things because omap-pcm was using 64bits for
> dma coherent mask.
Can you please try to understand _why_ it broke and post an explanation.
This breakage wasn't expected and shouldn't have happened.
More information about the Alsa-devel