[alsa-devel] [PATCH 9/9] ALSA: compress: use rate values for passing sampling rates
broonie at kernel.org
Tue Aug 27 16:27:26 CEST 2013
On Tue, Aug 27, 2013 at 06:56:41PM +0530, Vinod Koul wrote:
> > > - * @sampling_rate: sampling rate of audio
> > > + * @sampling_rate: sampling rate value of audio, eg 12000, 48000
> > It's not clear why this is a change in the ABI - the values written and
> > the types don't change. Personally I'd not change the ABI - it's a bit
> > late now that the code has been in the kernel for several releases.
> the problem is the meaning of sampling_rate. It was SND_PCM_RATE_XXX. It was a
> lack of foresight on my side, we should have done values which we are changing
> now to handle rates not defined here.
Given that the documentation didn't mention the constants and there's no
example users I'm not sure this is actually a change at all...
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel