[alsa-devel] [PATCH 7/8] ASoC: Move call to snd_soc_dapm_new_widgets() after snd_soc_dapm_auto_nc_codec_pins()

Lars-Peter Clausen lars at metafoo.de
Tue Aug 27 15:51:00 CEST 2013

Call snd_soc_dapm_new_widgets() before the auto non-connected pins have been
marked as not connected will power the system under the assumption that those
pins are connected. Once the pins have been marked as disconnected the system
there will be an additional power run. This can cause unnecessary power
transitions. Calling snd_soc_dapm_new_widgets() only after the pins have been
marked as non-connected avoids this.

Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
 sound/soc/soc-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index aef5e8c..c3c4906 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1816,12 +1816,12 @@ static int snd_soc_instantiate_card(struct snd_soc_card *card)
-	snd_soc_dapm_new_widgets(&card->dapm);
 	if (card->fully_routed)
 		list_for_each_entry(codec, &card->codec_dev_list, card_list)
+	snd_soc_dapm_new_widgets(&card->dapm);
 	ret = snd_card_register(card->snd_card);
 	if (ret < 0) {
 		dev_err(card->dev, "ASoC: failed to register soundcard %d\n",

More information about the Alsa-devel mailing list