[alsa-devel] [PATCH 4/8] ASoC; wm8904: Remove unnecessary call to snd_soc_dapm_new_widgets()

Lars-Peter Clausen lars at metafoo.de
Tue Aug 27 15:50:57 CEST 2013

The core will call snd_soc_dapm_new_widgets() once all components of the card
have been initialized, so there is no need to do this manually in the driver.
Calling it earlier also might result in a partially instantiated system being
powered up which cause undesired side effects.

Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
 sound/soc/codecs/wm8904.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c
index 91dfbfe..4dfa8dc 100644
--- a/sound/soc/codecs/wm8904.c
+++ b/sound/soc/codecs/wm8904.c
@@ -1202,7 +1202,6 @@ static int wm8904_add_widgets(struct snd_soc_codec *codec)
-	snd_soc_dapm_new_widgets(dapm);
 	return 0;

More information about the Alsa-devel mailing list