[alsa-devel] [PATCH v2 1/4] ALSA: hda - add flags and routines to get devices selection info for DP1.2 MST

[Takashi Iwai]

At Sun, 25 Aug 2013 17:44:11 -0400,
mengdong.lin at intel.com wrote:
> 
> @@ -460,6 +464,11 @@ enum {
>  #define AC_DEFCFG_PORT_CONN		(0x3<<30)
>  #define AC_DEFCFG_PORT_CONN_SHIFT	30
>  
> +/* Display pin's device list entry */
> +#define AC_DE_PD			(1<<0)
> +#define AC_DE_ELDV			(1<<1)
> +#define AC_DE_IA			(1<<2)
> +
>  /* device device types (0x0-0xf) */
>  enum {
>  	AC_JACK_LINE_OUT,
> @@ -795,6 +804,16 @@ struct hda_pcm {
>  	bool own_chmap;		/* codec driver provides own channel maps */
>  };
>  
> +/* display pin's device list entry */
> +struct  hda_devlist_entry {
> +	unsigned int present_detect:1;
> +	unsigned int eld_valid:1;
> +	unsigned int inactive:1;
> +};

Can't it be simply an unsigned int containing the raw value?
You defined the bit flag in the above, and copying the bit field
from/to the bit flag looks redundant.


thanks,

Takashi