[alsa-devel] [PATCH] ASoC: rt5640: change widgetsequencefordepop

[Bard Liao]

> -----Original Message-----
> From: Lars-Peter Clausen [mailto:lars at metafoo.de]
> Sent: Tuesday, August 06, 2013 5:36 PM
> To: Bard Liao
> Cc: Mark Brown; Oder Chiou; alsa-devel at alsa-project.org;
> swarren at nvidia.com; swarren at wwwdotorg.org; lgirdwood at gmail.com; Flove
> Subject: Re: [alsa-devel] [PATCH] ASoC: rt5640: change
> widgetsequencefordepop
> 
> On 08/06/2013 11:13 AM, Bard Liao wrote:
> >>> I think I need to use SND_SOC_DAPM_SWITCH with
> >> SOC_DAPM_SINGLE_AUTODISABLE for this control.
> >>> Am I right?
> >>> I am trying to do that, but meet a problem.
> >>> If I set speaker switch unmute before playing music, dapm will mute
> >>> it
> >> automatically in power on sequence.
> >>> The only way I can unmute speaker is set speaker switch unmute while
> >> playing music.
> >>
> >> DAPM should unmute the switch on power up and mute it on power down.
> >> The Speaker Channel Switch control has the invert flag set did you
> >> also set the invert flag for the new autodisable control?
> >
> > Yes, the related code is as below.
> > static const struct snd_kcontrol_new spk_l_enable_control =
> > 	SOC_DAPM_SINGLE_AUTODISABLE("Switch", RT5640_SPK_VOL,
> > 		RT5640_L_MUTE_SFT, 1, 1);
> >
> > static const struct snd_kcontrol_new spk_r_enable_control =
> > 	SOC_DAPM_SINGLE_AUTODISABLE("Switch", RT5640_SPK_VOL,
> > 		RT5640_R_MUTE_SFT, 1, 1);
> >
> > 	SND_SOC_DAPM_SWITCH("Speaker L Playback", SND_SOC_NOPM, 0, 0,
> > 			&spk_l_enable_control),
> > 	SND_SOC_DAPM_SWITCH("Speaker R Playback", SND_SOC_NOPM, 0, 0,
> > 			&spk_r_enable_control),
> 
> Looks good. Maybe I got the invert = 1 case wrong somewhere. Can you add a
> couple of printks and send me the result?

The result is as below.

[    9.418738] new control: Speaker R Playback Switch 1
[    9.423949] new control: Speaker L Playback Switch 1

root at tegra-ubuntu:/home/ubuntu# amixer cset name="Speaker L Playback Switch" 0
numid=25,iface=MIXER,name='Speaker L Playback Switch'
  ; type=BOOLEAN,access=rw------,values=1
  : values=off
root at tegra-ubuntu:/home/ubuntu# dmesg -c
[  163.717158] Speaker L Playback Switch->on_val = 1
root at tegra-ubuntu:/home/ubuntu#
root at tegra-ubuntu:/home/ubuntu# amixer cset name="Speaker L Playback Switch" 1
numid=25,iface=MIXER,name='Speaker L Playback Switch'
  ; type=BOOLEAN,access=rw------,values=1
  : values=on
root at tegra-ubuntu:/home/ubuntu#
root at tegra-ubuntu:/home/ubuntu# dmesg -c
[  174.482833] Speaker L Playback Switch->on_val = 0

> 
> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index
> 2da258b..18c62ae 100644
> --- a/sound/soc/soc-dapm.c
> +++ b/sound/soc/soc-dapm.c
> @@ -229,6 +229,9 @@
>   			template.id = snd_soc_dapm_kcontrol;
>   			template.name = kcontrol->id.name;
> 
> +			printk("new control: %s %d\n", template->name,
> +				template->off_val);
> +
>   			data->widget = snd_soc_dapm_new_control(widget->dapm,
>   				&template);
>   			if (!data->widget) {
> @@ -337,8 +340,10 @@
>   	if (data->value == value)
>   		return false;
> 
> -	if (data->widget)
> +	if (data->widget) {
>   		data->widget->on_val = value;
> +		printk("%s->on_val = %d\n", data->widget->name, value);
> +	}
> 
>   	data->value = value;
> 
> 
> ------Please consider the environment before printing this e-mail.