[alsa-devel] [PATCH] ASoC: dapm: Fix empty list check in dapm_new_mux()

Stephen Warren swarren at wwwdotorg.org
Fri Aug 2 17:43:50 CEST 2013

On 08/01/2013 12:44 PM, Mark Brown wrote:
> On Thu, Aug 01, 2013 at 06:30:38PM +0200, Lars-Peter Clausen
> wrote:
>> list_first_entry() will always return a valid pointer, even if
>> the list is empty. So the check whether path is NULL will always
>> be false. So we end up calling
>> dapm_create_or_share_mixmux_kcontrol() with a path struct that
>> points right in the middle of the widget struct and by trying to
>> modify the path the widgets memory will become corrupted. Fix
>> this by using list_emtpy() to check if the widget doesn't have
>> any paths.
> Applied, thanks - looking at this I'm surprised we've not been
> running into problems before.

I don't see this in the ASoC git tree, in either for-next, fix/dapm,
or topic/dapm.

More information about the Alsa-devel mailing list