[alsa-devel] [PATCH 17/17] ASoC: ux500: Use generic dmaengine PCM

Lee Jones lee.jones at linaro.org
Thu Apr 18 15:50:37 CEST 2013

On Mon, 15 Apr 2013, Lars-Peter Clausen wrote:

> Use the generic dmaengine PCM driver instead of a custom implemention.  There is
> a minor functional change, the ux500 PCM driver did not preallocate the audio
> buffer, while the generic dmaengine PCM driver will do this.
> Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
> ---
>  include/sound/dmaengine_pcm.h |   2 +-
>  sound/soc/ux500/Kconfig       |   2 +-
>  sound/soc/ux500/ux500_pcm.c   | 159 +++++-------------------------------------
>  3 files changed, 19 insertions(+), 144 deletions(-)

By rights you really need Ola's approval on this, but because:

a) ... this removes a hell of a lot of old code, and
b) ... using the new DMA APIs _is_ the correct thing to do, and
c) ... this aids me in getting the D40 DMA controller up-to-scratch, and
d) ... I have patches which rely on these changes, and
e) ... the driver is already pretty broken

... you can have my: Acked-by: Lee Jones <lee.jones at linaro.org>

Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

More information about the Alsa-devel mailing list