[alsa-devel] [PATCH] asoc: add dummy codec

[Lars-Peter Clausen]

On 04/11/2013 05:11 PM, Stas Sergeev wrote:
> 11.04.2013 14:41, Lars-Peter Clausen пишет:
>> On 04/11/2013 12:36 PM, Stas Sergeev wrote:
>>> Hi.
>>>
>>> The attached patch adds a dummy codec for the
>>> asoc subsystem.
>>> I use it with the driver that programs the soc to drive
>>> I2S from an internal PLLs, and the audio then goes to
>>> HDMI, so no external codec is used.
>>> I've found spdif_transciever.c, which exactly is such a
>>> dummy driver, but it is bound to the particular plat
>>> device, so I made the device name a config option, and
>>> if not set, the plat device is created with the default
>>> name.
>>>
>>> It may be possible to avoid the usage of the codec driver
>>> at all, but I haven't succeeded with this, and the existance
>>> of spdif_transciever.c suggests there is no such way.
>>> Thoughts?
>>>
>>> Signed-off-by: Stas Sergeev <stsp at users.sourceforge.net>
>>>
>> Hi,
>>
>> There is already a dummy codec driver.
>>
>> Please take a look at sound/soc/soc-utils.c
>>
>> - Lars
> Lars, indeed, this codec is present in a git kernel and
> it wasn't in mine android kernel.
> But, that driver is too dummy to even work at all.
> 
> The attached patch adds a playback stream for the dummy
> codec. Would it be possible to apply this?

Looks fine to me, although it might make sense to also add a dummy capture
stream. But you need to send the patch to Mark and Liam who are the ASoC
maintainers. Also use the proper subsystem prefix, which is "ASoC" not "asoc",
add a patch description, sign off on the patch itself and try to send it inline
instead of an attachment.

- Lars