[alsa-devel] [PATCH 2/3] ALSA: compress_core: Split copy into seperate read and write callbacks
broonie at opensource.wolfsonmicro.com
Tue Apr 9 13:47:28 CEST 2013
On Tue, Apr 09, 2013 at 04:45:07PM +0530, Vinod Koul wrote:
> On Fri, Apr 05, 2013 at 09:23:45AM +0100, Charles Keepax wrote:
> > On Thu, Apr 04, 2013 at 01:01:57PM -0500, Pierre-Louis Bossart wrote:
> > > Why not remove the const to make this consistent with the PCM interface?
> > I had been trying to avoid loosing the const from the write file
> > operation, however I am happy to just loose this through casting
> > instead. It is certainly a simpler change I will respin these to
> > do so.
> Keeping const of write seems to be a better idea... Ah i cant decide :(
> I will asker wiser folks... Takashi, Mark?
I generally prefer the const correctness, but on the other hand Pierre
is right about the PCM interface and it's probably more trouble than
it's worth to change that. So meh, dunno :/
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel