[alsa-devel] [PATCH v2 08/11] ASoC: fsl-ssi: imx ac97 support

Timur Tabi timur at tabi.org
Mon Apr 8 04:49:03 CEST 2013

Markus Pargmann wrote:
> This patch copies some parts from imx-ssi to support AC97 on
> imx27-pca100 and imx27-pcm043. It is activated with a new fsl,imx-ac97
> bool property. It was tested on imx27-pca100.

I'm not crazy about this patch -- it seems a bit hackish.  There are too 
many "if (imx_ac97)" clauses.  Large pieces of code that don't appear to 
be related to AC97 are indented in an if-clause.  I especially don't like 
the "If we use AC97, the registers are already setup correctly".

Timur Tabi

More information about the Alsa-devel mailing list