[alsa-devel] [PATCH 06/10] ALSA: usb-audio: UAC2: do clock validity check earlier

Torstein Hegge hegge at resisty.net
Mon Apr 1 10:16:51 CEST 2013

On Sun, Mar 31, 2013 at 17:52:28 +0200, Eldad Zack wrote:
> Move the check that parse_audio_format_rates_v2() do after
> receiving the clock source entity ID directly into the find
> function and add a validation flag to the function.
> This patch does not introduce any logic flow change.

What would be lost by letting __uac_clock_find_source() always check
that the clock source is valid? It would avoid having to pass the
validate parameter, at the cost of having parse_audio_format_rates_v2()
validate clock source.


More information about the Alsa-devel mailing list