[alsa-devel] [PATCH] ASoC: imx-audmux: remove null check of audmux_base in audmux_read_file

Richard Zhao richard.zhao at freescale.com
Tue Sep 18 10:38:30 CEST 2012

When audmux_read_file is called, it means the driver is already
initialised successfully, so we don't need to check audmux_base.

It also fix smatch warning:
sound/soc/fsl/imx-audmux.c:78 audmux_read_file() warn: possible memory leak of 'buf'

Signed-off-by: Richard Zhao <richard.zhao at freescale.com>
 sound/soc/fsl/imx-audmux.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
index e7c800e..524ce62 100644
--- a/sound/soc/fsl/imx-audmux.c
+++ b/sound/soc/fsl/imx-audmux.c
@@ -74,9 +74,6 @@ static ssize_t audmux_read_file(struct file *file, char __user *user_buf,
 	if (!buf)
 		return -ENOMEM;
-	if (!audmux_base)
-		return -ENOSYS;
 	if (audmux_clk)

More information about the Alsa-devel mailing list