[alsa-devel] [PATCH 1/4] ASoC: ak5702: add support for ak5702 -- 4ch ADC

[Mark Brown]

On Mon, Oct 29, 2012 at 09:43:57AM +0100, Paolo Doz wrote:
> This codec driver adds support for Asahi Kasei AK5702.
> 
> Signed-off-by: Paolo Doz <paolo.doz at gmail.com>

Lars-Peter already went through most of this so I'll not follow up in
detail.  One overall comment which Lars-Peter didn't make but which it's
worth bearing in mind was that your driver looks like it was written
several years ago, it'd probably help a lot if you were to look at more
modern drivers and make sure what you're doing resembles them
stylistically.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20121029/32d3bdf8/attachment.sig>