[alsa-devel] [PATCH 1/1] Add USB audio quirk supporting Roland VG-99 advanced mode

Takashi Iwai tiwai at suse.de
Sun Oct 21 12:13:15 CEST 2012


At Sun, 21 Oct 2012 10:34:57 +0100,
Pete Leigh wrote:
> 
> On 21 October 2012 09:40, Takashi Iwai <tiwai at suse.de> wrote:
> 
> > Could you give a bit more descriptive commit log?
> > I see you put more in comments, but it'd be also good to have more
> > information in the changelog.
> 
> Ok, done I hope.

Thanks, applied now.

> Perhaps it's worth noting - I ran the patch checking script, and it
> did not like the spaces after '&', nor line lengths, in a couple of
> places in the patch, but I obeyed the conventions of the existing code
> in the file rather than what the script said, and kept things as they
> were. Hope that's ok.

Don't worry about that.  checkpatch.pl is just too picky.


Takashi


More information about the Alsa-devel mailing list