[alsa-devel] [PATCH] ALSA: hda - Don't enable unsol for jacks we're polling

[Takashi Iwai]

At Wed, 17 Oct 2012 14:45:05 +0200,
David Henningsson wrote:
> 
> This will greatly reduce the frequency for detection errors in
> those cases where the hardware is "flaky", i e, rapidly changing
> between plugged and unplugged states even without user interaction.
> 
> Signed-off-by: David Henningsson <david.henningsson at canonical.com>

Thanks, applied.


Takashi

> ---
>  sound/pci/hda/hda_jack.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/hda_jack.c b/sound/pci/hda/hda_jack.c
> index 07d5288..5bdbada 100644
> --- a/sound/pci/hda/hda_jack.c
> +++ b/sound/pci/hda/hda_jack.c
> @@ -206,6 +206,8 @@ int snd_hda_jack_detect_enable_callback(struct hda_codec *codec, hda_nid_t nid,
>  		jack->action = action;
>  	if (cb)
>  		jack->callback = cb;
> +	if (codec->jackpoll_interval > 0)
> +		return 0; /* No unsol if we're polling instead */
>  	return snd_hda_codec_write_cache(codec, nid, 0,
>  					 AC_VERB_SET_UNSOLICITED_ENABLE,
>  					 AC_USRSP_EN | jack->tag);
> -- 
> 1.7.9.5
>