[alsa-devel] [PATCH] ALSA: hda - avoid unneccesary indices on "Headphone Jack" controls

[David Henningsson]

On 10/08/2012 10:18 AM, Takashi Iwai wrote:
> At Wed,  3 Oct 2012 11:12:53 +0200,
> David Henningsson wrote:
>>
>> In case there is one "Headphone Jack" and one "Dock Headphone Jack",
>> one of them will get an index, even though that is not needed.
>> This patch fixes that issue.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1060729
>> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
>
> Applied.  This one doesn't need to go to stable, right?

Good question. I guess it depends on how we look upon kcontrol indices 
in general.

PulseAudio never picks anything up if it has an index, therefore it 
becomes a real problem/bug for users. (Not sure if one could argue that 
this is a problem in PulseAudio rather than the kernel. Haven't thought 
that through.)

OTOH, if the reasoning is that you would break custom made scripts that 
depend on this index, i e it becomes a change of behaviour.

To be pragmatic about it, the chances that people are depending on this 
index being non-zero are probably very low, so I don't mind sending this 
one to stable.



-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic