[alsa-devel] [RFC][PATCH 0/2] ASoC: add DT support on simple-card

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Nov 29 05:31:03 CET 2012

Hi Mark

These patches add DT support for soc-simple-card driver.

Kuninori Morimoto (2):
      ASoC: add snd_soc_of_parse_daifmt()
      ASoC: simple-card: add DT support

 include/sound/soc.h             |    2 +
 sound/soc/generic/simple-card.c |   90 +++++++++++++++++++++++++++++++++++++--
 sound/soc/soc-core.c            |   72 +++++++++++++++++++++++++++++++
 3 files changed, 161 insertions(+), 3 deletions(-)

1st patch adds snd_soc_of_parse_daifmt() to select SND_SOC_DAIFMT_xxx,
but I'm not sure whether this is good idea.
So these are [RFC] patches.

I thought that it will be trouble if...
  1) platform/driver DT used snd_fmt = <0xYYYY> style for SND_SOC_DAIFMT_xxx
  2) someone might update SND_SOC_DAIFMT_xxx value for some reasons.
  3) bootloader should update DT value according to kernel version if 2) happened

I put snd_soc_of_parse_daifmt() on soc-core.c because I thought that other driver can reuse it.
I need your comment for it.

Best regards
Kuninori Morimoto

More information about the Alsa-devel mailing list