[alsa-devel] [PATCH 1/6] ALSA: PCM: Remove redundant null check before kfree

Sachin Kamat sachin.kamat at linaro.org
Wed Nov 21 10:06:54 CET 2012


kfree on a null pointer is a no-op.

Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
---
Build tested and based on linux-next 20121115.
---
 sound/core/pcm.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/sound/core/pcm.c b/sound/core/pcm.c
index 030102c..61798f8 100644
--- a/sound/core/pcm.c
+++ b/sound/core/pcm.c
@@ -981,8 +981,7 @@ void snd_pcm_detach_substream(struct snd_pcm_substream *substream)
 		       PAGE_ALIGN(sizeof(struct snd_pcm_mmap_control)));
 	kfree(runtime->hw_constraints.rules);
 #ifdef CONFIG_SND_PCM_XRUN_DEBUG
-	if (runtime->hwptr_log)
-		kfree(runtime->hwptr_log);
+	kfree(runtime->hwptr_log);
 #endif
 	kfree(runtime);
 	substream->runtime = NULL;
-- 
1.7.4.1



More information about the Alsa-devel mailing list