[alsa-devel] [PATCH 4/4] ASoC: firmware core: Add core support to create and destroy firmware components.

Takashi Iwai tiwai at suse.de
Wed Nov 21 07:43:03 CET 2012


At Wed, 21 Nov 2012 09:30:42 +0900,
Mark Brown wrote:
> 
> On Tue, Nov 20, 2012 at 12:03:25PM +0000, Liam Girdwood wrote:
> 
> > I think we are good with the magic number check atm and I can add
> > some explicit endianess conversion when we have more users. Atm, the
> > only users will be ARM based.
> 
> It's very likely that Wolfson will pick this up quickly for some of our
> devices.
> 
> Could we make the endianness annotations in the header explicit for now
> but refuse to handle anything except LE?

I guess Liam's idea is to check the first 4 magic bytes as endian
identifier, too ("ASoC" or "CoSA"), and refuse else than native one.
It would work, but I'm not sure whether this is the best form...

>  That way we avoid changing the
> externally visible interface which would be painful.  I'm not so worried
> about actually implementing this properly, just worried that people will
> get upset if we change the published ABI.

Yeah, this firmware spec will have been used for years, so the
compatibility issue should be well considered from the beginning.


thanks,

Takashi


More information about the Alsa-devel mailing list