[alsa-devel] [PATCH 0/10] Kirkwood ASoC drivers fixes and improvements

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Nov 20 13:20:51 CET 2012


Argh.  Just noticed the driver author is _not_ listed in MAINTAINTERS.
I guess the driver author doesn't care about receiving patches for his
driver then...  If Arnaud does care then that needs to be fixed.  I will
not be spamming everyone again with this patch set just because someone
can't be bothered to ensure that they have appropriate MAINTAINERS entries.
I'm sure they can be dug out of the alsa-devel archives instead.

On Tue, Nov 20, 2012 at 12:17:26PM +0000, Russell King - ARM Linux wrote:
> The first five patches of this patch series fixes a number of problems
> with the Kirkwood audio driver, as seen on Dove platforms.  The biggest
> issue is that they can cause the kernel to lock up solidly, requiring
> a reset to recover.
> 
> Other issues included in the first six patches are bugs found by the
> cubox folk.
> 
> The other five patches convert the I2S driver to use the devm_* APIs,
> improve the handling of the record and playback control registers so
> we're not reading and writing them as often, lift restrictions in the
> DMA driver which aren't necessary to impose, and add support for
> external clocks so that sample rates other than 44.1, 48 and 96kHz
> can be supported.  Some of these changes prepare the driver to support
> the SPDIF output including passthrough mode; however, that support is
> not included in this patch set.
> 
> These patches probably need checking out on Kirkwood before they go
> into mainline, but given the severity of the kernel lockup, I suggest
> that once tested the first five patches go into -rc.
> 
>  sound/soc/kirkwood/kirkwood-dma.c |   19 ++-
>  sound/soc/kirkwood/kirkwood-i2s.c |  291 ++++++++++++++++++++++---------------
>  sound/soc/kirkwood/kirkwood.h     |   11 +-
>  3 files changed, 197 insertions(+), 124 deletions(-)
> 
>  ASoC: kirkwood-dma: remove channel restrictions
>  ASoC: kirkwood-i2s: add support for external clock rates
>  ASoC: kirkwood-dma: remove restriction on sample rates
>  ASoC: kirkwood-i2s: better handling of play/record control registers
>  ASoC: kirkwood-i2s: use devm_* APIs
>  ASoC: kirkwood-i2s: more pause-mode fixes
>  ASoC: kirkwood-i2s: fix DMA underruns
>  ASoC: kirkwood-i2s: fix DCO lock detection
>  ASoC: kirkwood-dma: don't ignore other irq causes on error
>  ASoC: kirkwood-dma: fix use of virt_to_phys()
> 


More information about the Alsa-devel mailing list