[alsa-devel] Fix for Asus G75 notebook subwoofer

[Takashi Iwai]

At Wed, 07 Nov 2012 16:51:01 +0100,
Massimo Del Fedele wrote:
> 
> Il 07/11/2012 14:45, Takashi Iwai ha scritto:
> > At Wed, 07 Nov 2012 14:37:33 +0100,
> > Massimo Del Fedele wrote:
> >>
> >>
> >> Il 07/11/2012 09:56, Takashi Iwai ha scritto:
> >>> At Tue, 06 Nov 2012 18:23:51 +0100,
> >>> Massimo Del Fedele wrote:
> >>>>
> >>>> Il 06/11/2012 15:24, Takashi Iwai ha scritto:
> >>>>> At Tue, 06 Nov 2012 15:18:58 +0100,
> >>>>> Massimo Del Fedele wrote:
> >>>>>> Il 06/11/2012 10:06, Takashi Iwai ha scritto:
> >>>>>>
> >>>>>>> Could you attach to ML too?
> >>>>>> I tried, but they're too big
> >>>>> Did you compress it?
> >>>> No, but I'm doing now... in compressed file are both info
> >>> Could you post also alsa-info.sh output before applying your patch,
> >>> too?
> >>>
> >>>>>>>> BTW, did you see the above patch (error in via_auto_fill_dac_nids) ?
> >>>>>>>> My patch isn't correct either (fails when the 'continue' path is taken)
> >>>>>>>> but it's better than now. I guess that code should be rewritten, it's
> >>>>>>>> quite weird in respect to dac numbering.
> >>>>>>> Could you elaborate a bit more?
> >>>>>>>
> >>>>>> Ok. here the original functions :
> >>>>> Hmm... could you give a "diff -up" output instead?
> >>>> Ok... here is te diff (with whole asus patch). I cleaned up the part of via_auto_fill_dac_nids,
> >>>> it should be correct now in all parts, even for skipped nids.
> >>> Actually the only place to be fixed is the assignment of
> >>> spec->private_dac_nids[].  spec->out_path[] should correspond to
> >>> cfg->line_out_pins[].  That is, the patch below should suffice (in
> >>> addition to pin default changes and connection overrides for VT1802).
> >>>
> >>>
> >>> thanks,
> >>>
> >>> Takashi
> >>>
> >>> ---
> >>> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
> >>> index 72a2f60..1c1367b 100644
> >>> --- a/sound/pci/hda/patch_via.c
> >>> +++ b/sound/pci/hda/patch_via.c
> >>> @@ -1825,7 +1825,7 @@ static int via_auto_fill_dac_nids(struct hda_codec *codec)
> >>>    					    &spec->out_mix_path))
> >>>    			dac = spec->out_mix_path.path[0];
> >>>    		if (dac) {
> >>> -			spec->private_dac_nids[i] = dac;
> >>> +			spec->private_dac_nids[dac_num] = dac;
> >>>    			dac_num++;
> >>>    		}
> >>>    	}
> >>>
> >>>
> >>>
> >> Hi...  not tested, but IMHO your patch won't  be enough; you're not updating the spec->multiout.num_dacs inside the loop,
> >> which means that is_empty_dac(codec, conn[i]) inside __parse_output_path() wil
> > l not detect used DACs as used :
> >
> > Ah, good point.  Fixed now.
> >
> >
> > Takashi
> >
> 
> Working well now; this is the verbose dmesg output :
> 
> [  920.868350] ALSA hda_auto_parser.c:664 >hda_codec: VT1802: Apply pincfg for Asus G75
> [  920.868367] ALSA hda_auto_parser.c:318 autoconfig: line_outs=2 (0x24/0x33/0x0/0x0/0x0) type:speaker
> [  920.868371] ALSA hda_auto_parser.c:322    speaker_outs=0 (0x0/0x0/0x0/0x0/0x0)
> [  920.868374] ALSA hda_auto_parser.c:326    hp_outs=1 (0x25/0x0/0x0/0x0/0x0)
> [  920.868376] ALSA hda_auto_parser.c:327    mono: mono_out=0x0
> [  920.868378] ALSA hda_auto_parser.c:330    dig-out=0x2d/0x0
> [  920.868380] ALSA hda_auto_parser.c:331    inputs:
> [  920.868384] ALSA hda_auto_parser.c:335      Internal Mic=0x29
> [  920.868387] ALSA hda_auto_parser.c:335      Mic=0x2b
> [  920.868631] ALSA patch_via.c:1861 output-path: depth=4, 08/34/14/24/00
> [  920.868647] ALSA patch_via.c:1861 output-path: depth=4, 08/21/14/24/00
> [  920.868861] ALSA patch_via.c:1861 output-path: depth=4, 09/3c/1c/33/00
> [  920.869321] ALSA patch_via.c:1861 output-path: depth=4, 08/35/15/25/00
> [  920.869325] ALSA patch_via.c:1861 output-path: depth=4, 08/21/15/25/00
> 
> Which seems ok to me.
> As before, I now have 2 front speakers (correctly) and 2 rear speakers, going to mono subwoofer.
> I don't know if it's a correct behaviour or not.

It's OK, just missing the stereo capability check in the mixer code,
but almost harmless.  Which channel (left or right) of "surround"
mixer actually controls the volume of subwoofer on your machine?


Takashi