[alsa-devel] [patch] ALSA: hda - unlock on error in azx_interrupt()

Dan Carpenter dan.carpenter at oracle.com
Fri May 18 09:36:11 CEST 2012


There is an spin_unlock() missing on this error path.

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
This was added recently in a82d51ed2 "ALSA: hda - Support
VGA-switcheroo".  I don't have the hardware so I haven't tested it.

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index bbf953f..2b6392b 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1268,8 +1268,10 @@ static irqreturn_t azx_interrupt(int irq, void *dev_id)
 
 	spin_lock(&chip->reg_lock);
 
-	if (chip->disabled)
+	if (chip->disabled) {
+		spin_unlock(&chip->reg_lock);
 		return IRQ_NONE;
+	}
 
 	status = azx_readl(chip, INTSTS);
 	if (status == 0) {


More information about the Alsa-devel mailing list