[alsa-devel] [PATCH] ASoC: twl6040: Remove HS/HF gain ramp feature

Peter Ujfalusi peter.ujfalusi at ti.com
Tue May 8 13:46:54 CEST 2012


On 05/07/2012 08:27 PM, Mark Brown wrote:
> On Fri, May 04, 2012 at 03:17:20PM +0300, Peter Ujfalusi wrote:
>> None of the machines uses the gain ramp possibility for HS/HF.
>> This code path is mostly unused and it does not reduces the pop
>> noise on the output (it alters it to sound a bit different).
>> The preferred method to reduce pop noise is to use ABE.
> ...to implement gain changes?

To fix up the pop noise.

After this feature was implemented to reduce the pop noise it become
clear that the underlying issue can be better solved with the offset
cancellation feature within ABE.
It turned out that the ramp code (which was implemented and deployed at
the same time as the ABE offset cancellation) alone just alters the
quality of the pop. With the ABE solution alone we are fine.

> Applied, thanks.

Thank you,

More information about the Alsa-devel mailing list