[alsa-devel] [PATCH] ASoC: sgtl5000: Enable VAG when DAC/ADC up

[Dong Aisheng-B29396]

> -----Original Message-----
> From: alsa-devel-bounces at alsa-project.org [mailto:alsa-devel-
> bounces at alsa-project.org] On Behalf Of Mark Brown
> Sent: Thursday, March 29, 2012 7:16 PM
> To: Shawn Guo
> Cc: alsa-devel at alsa-project.org; Zeng Zhaoming
> Subject: Re: [alsa-devel] [PATCH] ASoC: sgtl5000: Enable VAG when DAC/ADC
> up
> 
> On Thu, Mar 29, 2012 at 01:51:45PM +0800, Shawn Guo wrote:
> 
> > +	SND_SOC_DAPM_ADC_E("ADC", "Capture", SGTL5000_CHIP_ANA_POWER, 1, 0,
> > +			power_vag_event,
> > +			SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD),
> > +	SND_SOC_DAPM_DAC_E("DAC", "Playback", SGTL5000_CHIP_ANA_POWER, 3, 0,
> > +			power_vag_event,
> > +			SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD),
> 
> What would be more idiomatic here would be to make VAG a supply widget
> and then connect it to DAC and ADC rather than have the event on both -
> It looks like with your current code simultaneous playback and capture
> will break, you'll run through the power sequences twice and if you stop
> one stream it'll power down the other.
> 
It's true.

Regards
Dong Aisheng