[alsa-devel] [PATCH] ASoC: cs4270: Check that we can enable regulators on resume

Timur Tabi timur at freescale.com
Mon Mar 19 18:46:24 CET 2012


Mark Brown wrote:
> It's possible that the regulator enable will fail and if it does we may
> as well just give up with trying to bring the rest of the device up and
> report the original error.
> 
> Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
> ---

  CC      sound/soc/codecs/cs4270.o
/home/b04825/git/alsa.guts/sound/soc/codecs/cs4270.c: In function
'cs4270_soc_resume':
/home/b04825/git/alsa.guts/sound/soc/codecs/cs4270.c:605:2: error: 'ret'
undeclared (first use in this function)
/home/b04825/git/alsa.guts/sound/soc/codecs/cs4270.c:605:2: note: each
undeclared identifier is reported only once for each function it appears in

When I add 'int ret;', it compiles and works.  Note, however, that I have
no regular support on this board, so I don't know what I'm really testing.


On a side note, 'reg' should be an 'unsigned int', not an 'int'.

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the Alsa-devel mailing list