[alsa-devel] [PATCH 14/16] ASoC: Ux500: Add platform-driver

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Mar 14 13:31:27 CET 2012


On Wed, Mar 14, 2012 at 11:50:28AM +0100, Linus Walleij wrote:
> On Tue, Mar 13, 2012 at 11:48 PM, Mark Brown

> >> +     cdesc = dma_dev->device_prep_dma_cyclic(ux500_pcm_data->pipeid, dma_addr,
> >> +                                             period_cnt * period_len, period_len,
> >> +                                             direction);

> > You're using dmaengine here it seems.  Please refactor to use the
> > dmaengine helper library that was recently contributed by Lars-Peter -
> > it should save a bunch of code and make rolling out dmaengine framework
> > improvements much easier.

> That stuff is not even in linux-next so I don't know it it will even be
> in v3.4. But let's see.

You're not looking at a recent -next, it's been there for a while now.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120314/9b545949/attachment.sig 


More information about the Alsa-devel mailing list