[alsa-devel] [PATCH 10/16] arm: ux500: Add support for MSP I2S-devices

Linus Walleij linus.walleij at linaro.org
Wed Mar 14 10:39:03 CET 2012


On Tue, Mar 13, 2012 at 10:40 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Tue, Mar 13, 2012 at 04:11:37PM +0100, Ola Lilja wrote:
>
>>  arch/arm/mach-ux500/board-mop500-msp.c |  194 ++++++++++++++++++++++++++++++++
>>  arch/arm/mach-ux500/board-mop500.c     |    7 +-
>>  arch/arm/mach-ux500/board-mop500.h     |    1 +
>
> Perhaps this is somehow idiomatic for the port but why is this in what
> looks like a board specific rather than SoC specific file?

Basically because it includes GPIO's which are board-specific.

But with some cleverness I guess it'd be possible to split just
the board-dependent stuff (i.e. GPIO) to board-mop500-msp.c
and all SoC-specific stuff into say cpu-db8500-msp.c or
even cpu-dbx500-msp.c if it's generic across all families
of DBx500.

FOr short term, since the midterm plan is to use device tree
for the whole shebang (I guess).

Yours,
Linus Walleij


More information about the Alsa-devel mailing list