[alsa-devel] [PATCH] ASoC: omap-mcbsp: Export functions for threshold configuration

Liam Girdwood lrg at ti.com
Mon Mar 12 13:10:30 CET 2012

On Mon, 2012-03-12 at 11:59 +0000, Mark Brown wrote:
> On Mon, Mar 12, 2012 at 01:01:04PM +0200, Peter Ujfalusi wrote:
> > ABE has certain requirements towards the FIFO configuration in McBSP.
> > Make it posssible to configure the McBSP FIFO threshold from outside of
> > the McBSP driver stack.
> You should always submit things like this along with the changes which
> use them, it's much easier to see if they're sensible when the users are
> there.  Without seeing how this is used it's hard to tell if this is
> sensible or if it should be abstracted in some way and we don't want to
> have half of the bodges sitting around if we end up doing things a
> different way.

I agree, but in this case the ABE series will be huge. We're trying to
break this into smaller and more digestible chunks rather than a massive

The commit message here should have been more descriptive and described
the ABE use case.


More information about the Alsa-devel mailing list