[alsa-devel] [PATCH v2] ASoC: mx27vis-aic32x4: Convert it to platform driver

[javier Martin]

Hi Fabio,

On 12 March 2012 12:11, Fabio Estevam <festevam at gmail.com> wrote:
> Hi Javier.
>
> On Mon, Mar 12, 2012 at 5:03 AM, javier Martin
> <javier.martin at vista-silicon.com> wrote:
>>
>> I agree with the patch. However, I think another patch, which
>> registers this platform device for the visstrim_m10 board file
>> (http://lxr.linux.no/#linux+v3.2.9/arch/arm/mach-imx/mach-imx27_visstrim_m10.c)
>> should be applied at the same time. Otherwise, audio would stop
>> working on this platform and that would be a regression.
>
> The first hunk of this patch does register the audio device inside
> arch/arm/mach-imx/mach-imx27_visstrim_m10.c:
>
> diff --git a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c
> b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c
> index 0a1643c..ed6023f 100644
> --- a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c
> +++ b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c
> @@ -397,6 +397,7 @@ static void __init visstrim_m10_board_init(void)
>                                     &iclink_tvp5150, sizeof(iclink_tvp5150));
>       gpio_led_register_device(0, &visstrim_m10_led_data);
>       visstrim_camera_init();
> +       imx_add_platform_device("mx27vis", 0, NULL, 0, NULL, 0);
>  }
>
> Did I miss anything?

Sorry, I missed it, it was quite early in the morning...

Could you please provide a git repository and a branch for me to test
this patch?

Regards.
-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com