[alsa-devel] [PATCH 3/3] ASoC: omap-mcbsp: make minimum period size larger than FIFO
notasas at gmail.com
Fri Mar 9 00:19:17 CET 2012
With a program operating in minimum sized periods, first write
will cause a transfer that will fill mcbsp FIFO quickly, and there
will be no more data to DMA before program manages to do another
write. As the core considers this as underflow condition, we may
get many underflows at the start.
Increase minimum period size by half to deal with this problem.
Signed-off-by: Grazvydas Ignotas <notasas at gmail.com>
sound/soc/omap/omap-mcbsp.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index b9d1272..b373a0b 100644
@@ -108,6 +108,17 @@ static int omap_mcbsp_hwrule_min_period_size(struct snd_pcm_hw_params *params,
size = mcbsp->pdata->buffer_size;
frames.min = size / channels->min;
+ * If period is not larger than FIFO, it may be transfered faster than
+ * program operating in period sizes is able to send 2 periods, so
+ * underrun condition can be triggered at the beginning of stream.
+ * This is because underrun is triggered as soon as DMA has no more
+ * data to send, and we get this from the start if period is too small.
+ * To deal with this, set period larger than FIFO size.
+ frames.min = frames.min + frames.min / 2;
frames.integer = 1;
return snd_interval_refine(period_size, &frames);
More information about the Alsa-devel